PICARD-2958: Handle gettext being called with empty string #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling gettext("") by default returns the header of the PO file for the
current locale. This is unexpected. Return an empty string instead.
zas
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Calling gettext("") by default returns the header of the PO file for the current locale. This is unexpected. Return an empty string instead.
While PICARD-2958 effectively only happens on the 2.x branch due to recent refactorings of itemviews, the behavior of gettext itself is unexpected and can easily cause similar issues.
Solution
Update the gettext wrapper to return an empty string if the input was an empty string.