PICARD-2960: Prevent dir separator replacement being set to dir separator #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a config upgrade hook to sanitize the option |
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
It must not be possible to configure the replacement for directory separators to be a separator itself.
Solution
Add a validator to the dir separator option input to disallow
os.sepandos.altsep. Also validate on form close. While theoretically users can no longer configure this it can happen on upgrade and also when moving config from a platform withoutos.altsep(e.g. Linux) to one with (Windows where altsep is a backslash), or in general if separators differ between platforms.