Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-2989: fix settings override recursion #2544

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

phw
Copy link
Member

@phw phw commented Oct 9, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

The ScriptEditorDialog uses SettingsOverride for locally changed settings. On repeated example file updates the SettingsOverride would recursively reference itself. As there are many example updates on selection change this could lead to a deep recursion depth until max recursion would trigger an error.

Solution

Fix SettingsOverride always referencing base settings only.

Also avoid example update calls if the script editor dialog is not visible. The edittor will update anyway once it becomes visible or gains focus.

The examples will automatically update if the editor becomes visible
or gains focus.
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit 3528c59 into metabrainz:master Oct 9, 2024
44 checks passed
@phw phw deleted the PICARD-2989-fix-settings-override branch October 9, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants