Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to google calendar rewrite #148

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gwydion67
Copy link

@gwydion67 gwydion67 commented Oct 24, 2024

Rewrite the logic used to add to google calendar.
Now uses the ICS file from generate_ics to insert events into the google calendar
Main benefits :

  • more robust login and better error view
  • adding event types in future will be faster since only need to update the generate_ics part
  • option to add the calendar name as argument when running gyft.py, this calendar must be created beforehand on the google calendar website else the primary calendar will be used

Google Calendar importing now asks if full calendar is to imported or only the current semester

@proffapt proffapt requested a review from ashwinpra October 24, 2024 05:22
@proffapt
Copy link
Member

full calendar is to imported or only the current semester

what does full and current mean here?

@gwydion67
Copy link
Author

gwydion67 commented Oct 24, 2024

full calendar is to imported or only the current semester

what does full and current mean here?

Full : all events (both semestersl
Current : if the date of executing the code is before end of midsems then events before mids or if the date is after mids then put in entries from midsems to end sems

@gwydion67
Copy link
Author

gwydion67 commented Oct 24, 2024

I have improve on this logic, I want to remove the hard coded mid and end sems date and get them from the academic calendar but need that pr (fetch academic calendar #147 ) to be merged first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants