Return all project ids a tenant is member of within a given tenant #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit91
reviewed
Jul 2, 2024
There was a problem hiding this comment.
This looks pretty good to me now. I have two more questions though:
- The PR title says you want toreturn the project annotations as well. Is this still planned? Because I think it's not happening at the moment.
- In your test case, the Github tenant has a tenant membership with editor annotation, so implicitly he has access to all projects of the Github tenant. Why is there only project
1returned?
|
@simcod Ping? |
Sorry, did not had time yet. Will have a look at it in the next few days. |
simcod
changed the title
I have updated the PR name and test case. |
Co-authored-by: Gerrit <[email protected]>
Co-authored-by: Gerrit <[email protected]>
Gerrit91
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.