Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass partition id during machine register #142

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Oct 11, 2024

References

Closes #issue.

Additional Description

The partition ID is now passed from the pixie-core and sent to metal-api during registration. This reduces the load on the metal-api

Release Notes

None

@majst01 majst01 marked this pull request as ready for review October 11, 2024 06:38
@majst01 majst01 requested a review from a team as a code owner October 11, 2024 06:38
@majst01 majst01 requested review from mwennrich and Gerrit91 October 11, 2024 07:13
@majst01
Copy link
Contributor Author

majst01 commented Nov 12, 2024

This works in our test environment:

{"time":"2024-11-12T10:11:00.497136754Z","level":"INFO","msg":"register","machineID":"00000000-0000-0000-0000-ac1f6b7aeb76","request":{"uuid":"00000000-0000-0000-0000-ac1f6b7aeb76","hardware":{"memory":103079215104,"disks":[{"name":"/dev/nvme0n1","size":800166076416},{"name":"/dev/nvme1n1","size":800166076416},{"name":"/dev/sda","size":63350767616
}],"nics":[{"mac":"ac:1f:6b:94:ca:70","name":"eth0"},{"mac":"ac:1f:6b:94:ca:71","name":"eth1"},{"mac":"ac:1f:6b:94:ca:72","name":"eth2"},{"mac":"ac:1f:6b:94:ca:73","name":"eth3"},{"mac":"ac:1f:6b:7a:eb:76","name":"eth4","neighbors":[{"mac":"b8:6a:97:74:00:3d","name":"swp1s2","hostname":"fra-equ01-r01leaf01","identifier":"b8:6a:97:74:00:3d"}]},{"ma
c":"ac:1f:6b:7a:eb:77","name":"eth5","neighbors":[{"mac":"Eth1/3(Port1)","name":"Ethernet2","hostname":"fra-equ01-r01leaf02-1","identifier":"Eth1/3(Port1)"}]},{"mac":"00:00:00:00:00:00","name":"lo"}],"cpus":[{"vendor":"GenuineIntel","model":"Intel(R) Xeon(R) Silver 4110 CPU @ 2.10GHz","cores":8,"threads":16},{"vendor":"GenuineIntel","model":"Intel
(R) Xeon(R) Silver 4110 CPU @ 2.10GHz","cores":8,"threads":16}]},"bios":{"version":"3.4","vendor":"American Megatrends Inc.","date":"11/03/2020"},"ipmi":{"address":"10.1.1.130:623","mac":"ac:1f:6b:32:f0:94","user":"metal","password":"3dZz5iN8sR","interface":"lanplus","fru":{"chassis_part_number":"CSE-217BHQ+-R2K22BP2","chassis_part_serial":"C217BA
H31AG0535","board_mfg":"Supermicro","board_mfg_serial":"","board_part_number":"X11DPT-B","product_manufacturer":"Supermicro","product_part_number":"SYS-2029BT-HNTR","product_serial":"A328789X9108135C"},"bmc_version":"1.73"},"metal_hammer_version":"427f3b7","partition_id":"fra-equ01"}}                                                                
{"time":"2024-11-12T10:11:00.5642938Z","level":"INFO","msg":"machine registered","machineID":"00000000-0000-0000-0000-ac1f6b7aeb76","response":{"uuid":"00000000-0000-0000-0000-ac1f6b7aeb76","size":"c1-xlarge-x86","partition_id":"fra-equ01"}}  

Would have failed if no partition would have been passed.

@majst01 majst01 merged commit ffa8a0c into master Nov 12, 2024
1 check passed
@majst01 majst01 deleted the pass-partition-to-machine-register branch November 12, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants