reorg organization methods, add new method, update linter/CI (#131)

Signed-off-by: Stephen Hwang <[email protected]>

.buildkite/pipeline.yml

@@ -10,7 +10,7 @@ steps:
     - docker#v5.11.0:
         environment:
           - GOFLAGS=-buildvcs=false
-        image: "registry.hub.docker.com/golangci/golangci-lint:v1.57-alpine"
+        image: "registry.hub.docker.com/golangci/golangci-lint:v1.60.3-alpine"
         command: ["golangci-lint", "run", "-v", "--timeout", "5m"]
 
 - label: ":test_tube: test"

.golangci.yml

@@ -17,11 +17,11 @@ linters:
     - bodyclose
     - gocritic
     - gocyclo
-    - goerr113
+    - err113
     - gofmt
     - gofumpt
     - goimports
-    - gomnd
+    - mnd
     - govet
     - misspell
     - noctx

pkg/client/governor.go

@@ -2,18 +2,14 @@ package client
 
 import (
 	"context"
-	"fmt"
 	"net/http"
 	"net/url"
 	"sync"
 	"time"
 
-	"github.com/goccy/go-json"
 	"go.uber.org/zap"
 	"golang.org/x/oauth2"
 	"golang.org/x/oauth2/clientcredentials"
-
-	"github.com/metal-toolbox/governor-api/pkg/api/v1alpha1"
 )
 
 const (
@@ -153,59 +149,3 @@ func (c *Client) newGovernorRequest(ctx context.Context, method, u string) (*htt
 
 	return req, nil
 }
-
-// Organizations gets the list of organizations from governor
-func (c *Client) Organizations(ctx context.Context) ([]*v1alpha1.Organization, error) {
-	req, err := c.newGovernorRequest(ctx, http.MethodGet, fmt.Sprintf("%s/api/%s/organizations", c.url, governorAPIVersionAlpha))
-	if err != nil {
-		return nil, err
-	}
-
-	resp, err := c.httpClient.Do(req.WithContext(ctx))
-	if err != nil {
-		return nil, err
-	}
-
-	defer resp.Body.Close()
-
-	if resp.StatusCode != http.StatusOK {
-		return nil, ErrRequestNonSuccess
-	}
-
-	out := []*v1alpha1.Organization{}
-	if err := json.NewDecoder(resp.Body).Decode(&out); err != nil {
-		return nil, err
-	}
-
-	return out, nil
-}
-
-// Organization gets the details of an org from governor
-func (c *Client) Organization(ctx context.Context, id string) (*v1alpha1.Organization, error) {
-	if id == "" {
-		return nil, ErrMissingOrganizationID
-	}
-
-	req, err := c.newGovernorRequest(ctx, http.MethodGet, fmt.Sprintf("%s/api/%s/organizations/%s", c.url, governorAPIVersionAlpha, id))
-	if err != nil {
-		return nil, err
-	}
-
-	resp, err := c.httpClient.Do(req.WithContext(ctx))
-	if err != nil {
-		return nil, err
-	}
-
-	defer resp.Body.Close()
-
-	if resp.StatusCode != http.StatusOK {
-		return nil, ErrRequestNonSuccess
-	}
-
-	out := v1alpha1.Organization{}
-	if err := json.NewDecoder(resp.Body).Decode(&out); err != nil {
-		return nil, err
-	}
-
-	return &out, nil
-}