Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code quality issues introduced in TLS flags PR #1320

Closed
3 tasks done
tuminoid opened this issue Aug 2, 2023 · 7 comments
Closed
3 tasks done

Fix code quality issues introduced in TLS flags PR #1320

tuminoid opened this issue Aug 2, 2023 · 7 comments
Assignees
@tuminoid @adilGhaffarDev
Labels
triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@tuminoid
Copy link
Member

tuminoid commented Aug 2, 2023 •
edited by adilGhaffarDev
Loading

What steps did you take and what happened:
#1282 was merged and some code quality issues were raised after merging.

Environment:

/triage accepted
/assign @as20203
@metal3-io-bot metal3-io-bot added the triage/accepted Indicates an issue is ready to be actively worked on. label Aug 2, 2023
@tuminoid tuminoid mentioned this issue Aug 2, 2023
Merged
@as20203 as20203 mentioned this issue Aug 9, 2023
Merged
@as20203
Copy link
Member

as20203 commented Aug 9, 2023 •
edited
Loading

FIxed code quality issues in PR 1327

This was referenced Aug 14, 2023
Merged
Merged
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2023
@adilGhaffarDev
Copy link
Member

cc @adilGhaffarDev

@Rozzii Rozzii assigned tuminoid and adilGhaffarDev and unassigned as20203 Nov 22, 2023
@Rozzii
Copy link
Member

Rozzii commented Nov 22, 2023

/remove-lifecycle stale

1 similar comment
@Rozzii
Copy link
Member

Rozzii commented Nov 22, 2023

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2023
@adilGhaffarDev
Copy link
Member

@tuminoid can we close this issue if it is fixed? I see a merged PR that says it has fixed this issue: #1327

@tuminoid
Copy link
Member Author

Yes, this is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tuminoid tuminoid

@adilGhaffarDev adilGhaffarDev

Labels
triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tuminoid @Rozzii @adilGhaffarDev @as20203 @metal3-io-bot