Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fix code quality issues in TLS configuration code #289

Merged
merged 1 commit into from
Aug 15, 2023
Merged

🌱 Fix code quality issues in TLS configuration code #289

merged 1 commit into from
Aug 15, 2023

Conversation

as20203
Copy link
Member

@as20203 as20203 commented Aug 14, 2023

Fixed the code quality issues mentioned in 1320

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 14, 2023
@as20203 as20203 changed the title Jawad/ipam tls configuration 🌱 Fix code quality issues in IPAM TLS configuration code Aug 14, 2023
@as20203 as20203 force-pushed the jawad/ipam-tls-configuration branch 4 times, most recently from a18ef29 to eb7339a Compare August 14, 2023 09:05
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 14, 2023
@as20203 as20203 force-pushed the jawad/ipam-tls-configuration branch from eb7339a to 5e0edd9 Compare August 14, 2023 09:10
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2023
@as20203
Copy link
Member Author

as20203 commented Aug 14, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@as20203
Copy link
Member Author

as20203 commented Aug 14, 2023

@tuminoid please review.

@tuminoid tuminoid self-requested a review August 14, 2023 09:17
tuminoid
tuminoid reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@tuminoid
Copy link
Member

/retitle 🌱 Fix code quality issues in TLS configuration code

@metal3-io-bot metal3-io-bot changed the title 🌱 Fix code quality issues in IPAM TLS configuration code 🌱 Fix code quality issues in TLS configuration code Aug 14, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@metal3-io-bot metal3-io-bot merged commit 0bcb4cb into metal3-io:main Aug 15, 2023
4 checks passed
@adilGhaffarDev adilGhaffarDev mentioned this pull request Nov 27, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@as20203 @tuminoid @metal3-io-bot @furkatgofurov7