🌱 Introduce inspection delay for the fixture provisioner #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/M
Merged
metal3-io-bot
added
the
do-not-merge/work-in-progress
The fixture provisioner did have a delay previously, but it was removed as part of some work on reducing access to sensitive information. Now that we are running tests with the fixture provisioner, this has become an issue, since inspection happens so fast that it is hard to detect. This commit introduces artificial delay without accessing any extra information. Signed-off-by: Lennart Jern <[email protected]>
lentzi90
force-pushed
the
lentzi90/fixture-inspection-delay
branch
from
bc3d089
to
b1221a2
Compare
metal3-io-bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
/approve I'm not really fond of relying on timing here, but at least it improves the situation. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The fixture provisioner did have a delay previously, but it was removed as part of some work on reducing access to sensitive information. Now that we are running tests with the fixture provisioner, this has become an issue, since inspection happens so fast that it is hard to detect.
This commit introduces artificial delay without accessing any extra information.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #