-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Adjust test and linter timings #2046
🌱 Adjust test and linter timings #2046
Conversation
We have started hitting the deadline for golangci-lint. This commit doubles it from 5m to 10m. It also adjusts the fixture provisioners artificial inspection delay and the interval that is used when checking for it. Signed-off-by: Lennart Jern <[email protected]>
/test test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Hmm the second run also failed in the same way:
|
That is where it is waiting for the namespace to be deleted. I will look into this a bit more. Perhaps there are more deadlines that should be adjusted. |
What this PR does / why we need it:
We have started hitting the deadline for golangci-lint. This commit doubles it from 5m to 10m. It also adjusts the fixture provisioners artificial inspection delay and the interval that is used when checking for it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #