Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Adjust test and linter timings #2046

Merged

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Nov 8, 2024

What this PR does / why we need it:

We have started hitting the deadline for golangci-lint. This commit doubles it from 5m to 10m. It also adjusts the fixture provisioners artificial inspection delay and the interval that is used when checking for it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

We have started hitting the deadline for golangci-lint. This commit
doubles it from 5m to 10m. It also adjusts the fixture provisioners
artificial inspection delay and the interval that is used when checking
for it.

Signed-off-by: Lennart Jern <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Nov 8, 2024

/test test

@lentzi90
Copy link
Member Author

lentzi90 commented Nov 8, 2024

  • The test test passed. This was the one that hit golangci-lint timeout before.
  • The fixture test passed inspection. However, it failed in the cleanup. I believe it is this known flake. I will try retriggering.

/retest

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@Rozzii
Copy link
Member

Rozzii commented Nov 8, 2024

/retest

@lentzi90
Copy link
Member Author

lentzi90 commented Nov 8, 2024

Hmm the second run also failed in the same way:

   [FAILED] in [AfterEach] - /home/runner/work/baremetal-operator/baremetal-operator/test/e2e/common.go:130 @ 11/08/24 08:03:41.774
• [FAILED] [64.322 seconds]
Re-Inspection [AfterEach] should re-inspect the annotated BMH [required, re-inspection]
  [AfterEach] /home/runner/work/baremetal-operator/baremetal-operator/test/e2e/re_inspection_test.go:108
  [It] /home/runner/work/baremetal-operator/baremetal-operator/test/e2e/re_inspection_test.go:39

  [FAILED] Timed out after 60.000s.
  Expected
      <bool>: false
  to be true
  In [AfterEach] at: /home/runner/work/baremetal-operator/baremetal-operator/test/e2e/common.go:130

@lentzi90
Copy link
Member Author

lentzi90 commented Nov 8, 2024

That is where it is waiting for the namespace to be deleted. I will look into this a bit more. Perhaps there are more deadlines that should be adjusted.

@metal3-io-bot metal3-io-bot merged commit 08401af into metal3-io:main Nov 8, 2024
16 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/adjust-test-deadlines branch November 8, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants