Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Take new release workflow into use #2171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Jan 8, 2025

This workflow does an automatic tag, build and push images for a custom release when the note of that release is merged into the main branch.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2025
uses: metal3-io/project-infra/.github/workflows/container-image-build.yml@main
with:
image-name: 'baremetal-operator'
pushImage: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ref

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still missing ref

with:
image-name: 'keepalived'
dockerfile-directory: resources/keepalived-docker
pushImage: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ref

Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in BMO we create bit different tags, we create tag for pkg/hardwareutils/ too and instead api/ in BMO we have apis/

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/add-new-release-workflow branch 3 times, most recently from d1efe61 to f48e63d Compare January 8, 2025 12:21
or a new patch release from the latest release branch, uncheck the box for
latest release. If it is a release candidate (RC) or a beta release,
tick pre-release box.
- Github action `build-images-action` is triggered once tags are pushed from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not correct

- Github action `build-images-action` is triggered once tags are pushed from
above action. This action builds release image with the release tag in
Jenkins, and it gets pushed to Quay. Make sure the release tag is visible in
[Quay tags page](https://quay.io/repository/metal3-io/ip-address-manager?tab=tags).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ipam link

release until release tag is visible in. Runningactions are visible on the
[Actions](https://github.com/metal3-io/ip-address-manager/actions)
page, and draft release will be visible on top of the
[Releases](https://github.com/metal3-io/ip-address-manager/releases). If
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ipam link

minor.
- Github job `create draft release` creates draft release. Don't publish the
release until release tag is visible in. Runningactions are visible on the
[Actions](https://github.com/metal3-io/ip-address-manager/actions)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ipam link

- For any superseded PRs (like same dependency uplifted multiple times, or
commit revertions) that provide no value to the release, move them to
commit reversions) that provide no value to the release, move them to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reversions is wrong. Revertion is correct term.

This workflow does an automatic tag, build and push images for a custom
release when the note of that release is merged into the main branch.

Signed-off-by: Huy Mai <[email protected]>
@mquhuy mquhuy force-pushed the mquhuy/add-new-release-workflow branch from f48e63d to d07616a Compare January 8, 2025 14:58
@tuminoid
Copy link
Member

tuminoid commented Jan 9, 2025

Let's wait until we iterate the release documentation wording here: metal3-io/cluster-api-provider-metal3#2218
then its easier to sync to here, and not having to review two similar PRs.
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants