Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Added basic integration test #1101

Merged
merged 1 commit into from
Jul 25, 2023
Merged

🌱 Added basic integration test #1101

merged 1 commit into from
Jul 25, 2023

Conversation

huutomerkki
Copy link
Member

@huutomerkki huutomerkki commented Jul 21, 2023 •
edited by furkatgofurov7
Loading

This test will only create a cluster and collect logs from it. The resource flavor will be fixed here metal3-io/project-infra#554

Fixes: #897

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2023
@huutomerkki huutomerkki force-pushed the add-basic-integration-test/minna branch from f45db7d to bf13452 Compare July 24, 2023 09:33
@huutomerkki
Copy link
Member Author

/test-ubuntu-e2e-basic-main

@mboukhalfa
Copy link
Member

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@huutomerkki huutomerkki force-pushed the add-basic-integration-test/minna branch from bf13452 to 8fb19b7 Compare July 25, 2023 06:26
@huutomerkki
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@mboukhalfa
Copy link
Member

/test-ubuntu-e2e-basic-main

@mboukhalfa
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@mboukhalfa mboukhalfa changed the title ✨ Added basic integration test 🌱 Added basic integration test Jul 25, 2023
@huutomerkki
Added basic integration test
a0979d8 
This test will only create a cluster and collect logs from it.
@huutomerkki huutomerkki force-pushed the add-basic-integration-test/minna branch from 8fb19b7 to a0979d8 Compare July 25, 2023 10:09
@huutomerkki
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@mboukhalfa
Copy link
Member

/test-ubuntu-e2e-basic-main

furkatgofurov7
furkatgofurov7 reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huutomerkki, looks good to me!

Small nit on PR description:

Related issue: #897

I think this has to be changed to: Fixed: # in order to close the issue automatically once this is merged.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Jul 25, 2023 •
edited
Loading

/hold

to fix the description (feel free to unhold when it is ready :))

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@furkatgofurov7
Copy link
Member

/hold

to fix the description (feel free to unhold when it is ready :))

Should be fine now.

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@metal3-io-bot metal3-io-bot merged commit b839868 into metal3-io:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@mboukhalfa mboukhalfa mboukhalfa left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add basic e2e test without clusterctl move
4 participants
@huutomerkki @mboukhalfa @metal3-io-bot @furkatgofurov7