Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump github.com/golangci/golangci-lint from 1.47.1 to 1.54.1 in /hack/tools #1126

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 14, 2023

Bumps github.com/golangci/golangci-lint from 1.47.1 to 1.54.1.

Release notes

Sourced from github.com/golangci/golangci-lint's releases.

v1.54.1

golangci-lint is a free and open-source project, built by people in their free time. Also, the linter authors are an important part of golangci-lint. If you use and appreciate golangci-lint please think to support us (golangci-lint maintainers and linters authors). ❤️

Changelog

  • 9fc1e207 build(deps): bump github.com/go-critic/go-critic from 0.8.2 to 0.9.0 (#4000)
  • ea4481a1 build(deps): bump github.com/quasilyte/go-ruleguard from v0.3.19 to v0.4.0 (#3999)
  • a9378d9b plugin: temporarily hide warning about using plugins using the old API (#4002)

v1.54.0

golangci-lint is a free and open-source project, built by people in their free time. Also, the linter authors are an important part of golangci-lint. If you use and appreciate golangci-lint please think to support us (golangci-lint maintainers and linters authors). ❤️

Changelog

  • ffe688c2 build(deps): bump github.com/4meepo/tagalign from 1.2.2 to 1.3.1 (#3979)
  • e555470c build(deps): bump github.com/4meepo/tagalign from 1.3.1 to 1.3.2 (#3980)
  • 68b4988d build(deps): bump github.com/Abirdcfly/dupword from 0.0.11 to 0.0.12 (#3944)
  • d58342f0 build(deps): bump github.com/GaijinEntertainment/go-exhaustruct/v3 from 2.3.0 to 3.1.0 (#3963)
  • 6e31512a build(deps): bump github.com/ashanbrown/forbidigo from 1.5.3 to 1.6.0 (#3942)
  • c37828a8 build(deps): bump github.com/daixiang0/gci from 0.10.1 to 0.11.0 (#3994)
  • 78462c2b build(deps): bump github.com/go-critic/go-critic from 0.8.1 to 0.8.2 (#3978)
  • cecd497d build(deps): bump github.com/golangci/misspell 0.4.0 to 0.4.1 (#3918)
  • 1c67f591 build(deps): bump github.com/kunwardeep/paralleltest from 1.0.7 to 1.0.8 (#3985)
  • fc5a8f90 build(deps): bump github.com/nunnatsa/ginkgolinter from 0.12.1 to 0.12.2 (#3937)
  • 91afddc9 build(deps): bump github.com/nunnatsa/ginkgolinter from 0.12.2 to 0.13.0 (#3962)
  • 52793e78 build(deps): bump github.com/nunnatsa/ginkgolinter from 0.13.0 to 0.13.3 (#3972)
  • 0f31e51b build(deps): bump github.com/polyfloyd/go-errorlint from 1.4.2 to 1.4.3 (#3935)
  • c406ca5c build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.5 to 3.23.6 (#3936)
  • 1a32d402 build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.6 to 3.23.7 (#3989)
  • 2c0224fb build(deps): bump github.com/ultraware/funlen from 0.0.3 to 0.1.0 (#3988)
  • 67dd65fc build(deps): bump github.com/uudashr/gocognit from 1.0.6 to 1.0.7 (#3961)
  • bbcabb73 build(deps): bump github.com/ykadowak/zerologlint from 0.1.2 to 0.1.3 (#3923)
  • 17f6fcc9 build(deps): bump gitlab.com/bosi/decorder from 0.2.3 to 0.4.0 (#3959)
  • a303529a build(deps): bump go.tmz.dev/musttag from 0.7.0 to 0.7.1 (#3924)
  • a6caf8bf build(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 in /scripts/gen_github_action_config (#3991)
  • 043c368f build(deps): bump golang.org/x/oauth2 from 0.8.0 to 0.9.0 in /scripts/gen_github_action_config (#3920)
  • a56dfe8c build(deps): bump golang.org/x/oauth2 from 0.9.0 to 0.10.0 in /scripts/gen_github_action_config (#3946)
  • 6b7a9645 build(deps): bump golang.org/x/tools from 0.10.0 to 0.11.0 (#3943)
  • 29f9717f build(deps): bump golang.org/x/tools from 0.11.1 to 0.12.0 (#3992)
  • 7cf30e7b build(deps): bump golang.org/x/tools from 0.9.3 to 0.10.0 (#3914)
  • 494bb075 build(deps): bump semver from 5.7.0 to 5.7.2 in /tools (#3948)
  • e3ff6e7c build(deps): bump semver from 5.7.1 to 5.7.2 in /.github/contributors (#3947)
  • 9d32f6ec chore: fix nancy
  • 79c78d6f feat: explain typecheck and remove it from the linter list (#3929)
  • 6c7aba67 fix: include custom linters in enable-all (#3911)
  • c1d8c565 fix: trim Go version (#3995)
  • e0a8bd85 go1.21 support (#3922)

... (truncated)

Changelog

Sourced from github.com/golangci/golangci-lint's changelog.

v1.54.1

  1. updated linters:
    • go-critic: from 0.8.2 to 0.9.0
  2. misc.
    • plugin: temporarily hide warning about using plugins using the old API

v1.54.0

  1. updated linters:
    • decorder: from 0.2.3 to 0.4.0
    • dupword: from 0.0.11 to 0.0.12
    • errorlint: from 1.4.2 to 1.4.3
    • exhaustruct: from 2.3.0 to 3.1.0
    • forbidigo: from 1.5.3 to 1.6.0
    • funlen: from 0.0.3 to 0.1.0
    • gci: from 0.10.1 to 0.11.0
    • ginkgolinter: from 0.12.1 to 0.13.3
    • go-critic: from 0.8.1 to 0.8.2
    • go-errorlint: from 1.4.2 to 1.4.3
    • go-exhaustruct: from 2.3.0 to 3.1.0
    • gocognit: from 1.0.6 to 1.0.7
    • gocritic: from 0.8.1 to 0.8.2
    • gofmt: autofix missing newline at EOF
    • misspell: 0.4.0 to 0.4.1
    • musttag: from 0.7.0 to 0.7.1
    • paralleltest: from 1.0.7 to 1.0.8
    • tagalign: from 1.2.2 to 1.3.2
    • typecheck: explain it and remove it from the linter list
    • zerologlint: from 0.1.2 to 0.1.3
  2. misc.
    • 🎉 go1.21 support
    • plugin: include custom linters in enable-all
    • plugin: allow to use settings for plugins
  3. Documentation
    • Add linter descriptions.

Important

ruleguard (a "rule" inside gocritic) was disabled in this release (v1.54.0) and was enabled again in the next release (v1.54.1).

exhaustruct has breaking changes with regular expressions, more details here.

v1.53.3

  1. updated linters:
    • cyclop: from 1.2.0 to 1.2.1
    • exhaustive: from 0.10.0 to 0.11.0
    • forbidigo: from 1.5.1 to 1.5.3
    • ginkgolinter: from 0.12.2 to 0.12.1

... (truncated)

Commits
  • a9378d9 plugin: temporarily hide warning about using plugins using the old API (#4002)
  • 9fc1e20 build(deps): bump github.com/go-critic/go-critic from 0.8.2 to 0.9.0 (#4000)
  • ea4481a build(deps): bump github.com/quasilyte/go-ruleguard from v0.3.19 to v0.4.0 (#...
  • 03b1824 docs: Update documentation and assets (#3997)
  • c1d8c56 fix: trim Go version (#3995)
  • e0a8bd8 go1.21 support (#3922)
  • c37828a build(deps): bump github.com/daixiang0/gci from 0.10.1 to 0.11.0 (#3994)
  • 29f9717 build(deps): bump golang.org/x/tools from 0.11.1 to 0.12.0 (#3992)
  • a6caf8b build(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 in /scripts/gen_g...
  • 2c0224f build(deps): bump github.com/ultraware/funlen from 0.0.3 to 0.1.0 (#3988)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.47.1 to 1.54.1.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.47.1...v1.54.1)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 14, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 14, 2023
@tuminoid
Copy link
Member

/hold
/assign @kashifest

I thought we had bumped golangci to 1.52.x in #1028 and removed it from go.mod. Is this just a leftover?

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2023
@kashifest
Copy link
Member

kashifest commented Aug 15, 2023

I thought we had bumped golangci to 1.52.x in #1028 and removed it from go.mod. Is this just a leftover?

Yes it was a leftover. Here is the PR to remove it. #1129

@tuminoid
Copy link
Member

golangci-lint leftover will be removed from go.mod in #1129

/close

@metal3-io-bot
Copy link
Contributor

@tuminoid: Closed this PR.

In response to this:

golangci-lint leftover will be removed from go.mod in #1129

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 15, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/hack/tools/github.com/golangci/golangci-lint-1.54.1 branch August 15, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants