Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fix Centos e2e feature test badge #1959

Merged
merged 1 commit into from
Sep 5, 2024
Merged

🌱 Fix Centos e2e feature test badge #1959

merged 1 commit into from
Sep 5, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Sep 4, 2024

The current badge has wrong job name, hence the badge appears as "not run".

@mquhuy
Copy link
Member Author

mquhuy commented Sep 4, 2024

/retest

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Sep 4, 2024

/cc @tuminoid @mboukhalfa @adilGhaffarDev

tuminoid
tuminoid reviewed Sep 4, 2024
View reviewed changes
README.md Show resolved Hide resolved
Rozzii
Rozzii reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
@Rozzii
Copy link
Member

Rozzii commented Sep 5, 2024

/overwrite metal3-centos-e2e-integration-test-release-1-7

Test is not relevant as there is only doc change.

@Rozzii
Copy link
Member

Rozzii commented Sep 5, 2024

/override metal3-centos-e2e-integration-test-release-1-7

@metal3-io-bot
Copy link
Contributor

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-centos-e2e-integration-test-release-1-7

In response to this:

/override metal3-centos-e2e-integration-test-release-1-7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid
tuminoid reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@metal3-io-bot metal3-io-bot merged commit 10ed4b5 into metal3-io:release-1.7 Sep 5, 2024
12 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/fix-test-badge branch September 5, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @Rozzii @metal3-io-bot @tuminoid