-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Remove IPAM deployment logic #1993
base: main
Are you sure you want to change the base?
⚠️ Remove IPAM deployment logic #1993
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Should this be marked a breaking change as it is switching namespaces and hence upgrades are affected? |
Signed-off-by: peppi-lotta <[email protected]>
47d85ca
to
993dda2
Compare
/test metal3-ubuntu-e2e-integration-test-main |
@peppi-lotta: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
When making IPAm into a provider for CAPI, I needed to change the namespace where IPAM is living and how IPAM is deployed. This PR is made to match those changes in IPAM. There are also changes to metal-dev-env. These are the related PRs:
All three PRs' changes need to be tested together. Check test in the metal-dev-env PR.
What this PR does / why we need it: To be compatible with IPAM changes