🌱 bump golang to 1.23.3 and golangci-lint to 1.60.3 #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/M
|
/test metal3-centos-e2e-integration-test-release-1-8 |
3 tasks
Bump golang to 1.23.3 and golangci-lint to 1.60.3 which supports Go 1.23. Get rid of deprecated golangci-lint configs, and add timeout to the action, otherwise it'll be timed out in 1 minute. 15 minutes is consistent with "make lint" timeout. Linter fixes: - Fix new linter errors by removing the return value which is always nil (unparam linter), and thus meaningless. - "exportloopref" is not needed from Go 1.22 onwards, replaced by "copyloopvar" in golangci-lint 1.60.2. - Ambiguous string warnings in Wrapf fixed. Signed-off-by: Tuomo Tanskanen <[email protected]>
tuminoid
force-pushed
the
tuomo/bump-golang-1.23-1.8
branch
from
9b51dec
to
fe91126
Compare
|
/test metal3-centos-e2e-integration-test-release-1-8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 1.8: Bump golang to 1.23.3 and golangci-lint to 1.60.3 which supports Go 1.23.
Get rid of deprecated golangci-lint configs, and add timeout to the action, otherwise it'll be timed out in 1 minute. 15 minutes is consistent with "make lint" timeout.
Linter fixes:
Manual cherry-pick of #2087