Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to run Dev-env with FakeIPA #1450

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Add option to run Dev-env with FakeIPA #1450

merged 2 commits into from
Oct 22, 2024

Conversation

mboukhalfa
Copy link
Member

@mboukhalfa mboukhalfa commented Aug 26, 2024 •
edited
Loading

Run environment to test scalability with FakeIPA and also download FKAS image

To enable fakeIPA in devenv add the following line to the config file

export NODES_PLATFORM="fake"

Tested from : metal3-io/cluster-api-provider-metal3#2010

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2024
@metal3-io-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 26, 2024
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 29, 2024
@mboukhalfa mboukhalfa force-pushed the Integrate-fakeIPA/mohammed branch 2 times, most recently from faf54fb to f4a3e4d Compare August 29, 2024 17:22
@mboukhalfa mboukhalfa marked this pull request as ready for review August 29, 2024 17:29
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2024
@mboukhalfa mboukhalfa force-pushed the Integrate-fakeIPA/mohammed branch 2 times, most recently from 5047112 to fd4cf65 Compare August 30, 2024 06:26
@mboukhalfa mboukhalfa mentioned this pull request Aug 30, 2024
Merged
@mboukhalfa mboukhalfa force-pushed the Integrate-fakeIPA/mohammed branch 4 times, most recently from 200867f to 84aba16 Compare September 19, 2024 08:22
tuminoid
tuminoid reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some indentation issues.

03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
tuminoid
tuminoid reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, add the new environment variables to vars.md, same as sushy-tools vars are there.

03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
@mboukhalfa
Copy link
Member Author

/hold
Adding FKAS WIP

@mboukhalfa mboukhalfa changed the title Add option to run Dev-env with FakeIPA WIP Add option to run Dev-env with FakeIPA Sep 23, 2024
@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
@mboukhalfa mboukhalfa force-pushed the Integrate-fakeIPA/mohammed branch 4 times, most recently from 6a24885 to c062e18 Compare September 26, 2024 13:54
@mquhuy
Copy link
Member

mquhuy commented Oct 18, 2024

LGTM

smoshiur1237
smoshiur1237 reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mboukhalfa for adding the FakeIPA option with dev-env. I would request others to review it. After the review I can add approval.
LGTM

Rozzii
Rozzii requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits but generally looks good, thanks @mboukhalfa

01_prepare_host.sh Outdated Show resolved Hide resolved
02_configure_host.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
kashifest
kashifest reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits, otherwise lgtm

03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Show resolved Hide resolved
@kashifest
Copy link
Member

/cc @lentzi90

Rozzii
Rozzii requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the issues have been resolved, I still have ongoing question for one of the topics.

@mboukhalfa mboukhalfa force-pushed the Integrate-fakeIPA/mohammed branch 2 times, most recently from 00526e0 to a7e3c9b Compare October 22, 2024 06:23
@mboukhalfa
Copy link
Member Author

Most of the issues have been resolved, I still have ongoing question for one of the topics.

Addressed

lentzi90
lentzi90 reviewed Oct 22, 2024
View reviewed changes
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
04_verify.sh Outdated Show resolved Hide resolved
vm-setup/roles/common/tasks/write_ironic_nodes_tasks.yml Outdated Show resolved Hide resolved
tuminoid
tuminoid reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits.

03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-8
/test metal3-dev-env-integration-test-ubuntu-main

@mboukhalfa
Add Fake K8s API sever (FKAS) image
60e6614 
Signed-off-by: Mohammed Boukhalfa <[email protected]>
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-8
/test metal3-dev-env-integration-test-ubuntu-main

lentzi90
lentzi90 reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
Rozzii
Rozzii reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Looks great to me.

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@Rozzii Rozzii self-requested a review October 22, 2024 12:37
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 45a403e into metal3-io:main Oct 22, 2024
6 checks passed
@metal3-io-bot metal3-io-bot deleted the Integrate-fakeIPA/mohammed branch October 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@kashifest kashifest kashifest left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Rozzii approved these changes

@dtantsur dtantsur Awaiting requested review from dtantsur

@mquhuy mquhuy Awaiting requested review from mquhuy

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mboukhalfa @metal3-io-bot @mquhuy @kashifest @tuminoid @lentzi90 @Rozzii @smoshiur1237