Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove gosec, add test to capm3/ipam release-1.5 #582

Merged
merged 1 commit into from
Sep 26, 2023
Merged

remove gosec, add test to capm3/ipam release-1.5 #582

merged 1 commit into from
Sep 26, 2023

Conversation

tuminoid
Copy link
Member

Remove gosec from IPAM/CAPM3 release-1.5 branches, but add "make test" instead to match main.

Requires: metal3-io/cluster-api-provider-metal3#1218 and metal3-io/ip-address-manager#329 to be merged first.

/hold

@tuminoid
remove gosec, add test to capm3/ipam release-1.5
7a02d56 
Remove gosec from IPAM/CAPM3 release-1.5 branches, but add
"make test" instead to match main.
@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2023
@tuminoid
Copy link
Member Author

/test-ubuntu-integration-main

@tuminoid
Copy link
Member Author

/unhold
Deps merged.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2023
@tuminoid
Copy link
Member Author

/cc @lentzi90 @kashifest

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
lentzi90
lentzi90 reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@metal3-io-bot metal3-io-bot merged commit 6d3fbeb into metal3-io:main Sep 26, 2023
1 check passed
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Remove gosec from IPAM/CAPM3 release-1.5 branches, but add "make test" instead to match main.

Requires: metal3-io/cluster-api-provider-metal3#1218 and metal3-io/ip-address-manager#329 to be merged first.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the tuomo/remove-gosec-1.5 branch September 26, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @kashifest @metal3-io-bot @lentzi90