Presentation XML refactor, terms: https://github.com/metanorma/isodoc… #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @i18n = @i18n_lg[lg] if lg && @i18n_lg[lg] | ||
| elem.replace(l10n("#{@i18n.source}: #{sources}")) | ||
| @i18n = @i18n_lg["default"] | ||
| end |
There was a problem hiding this comment.
end at 237, 4 is not aligned with def at 231, 6.
| lg = elem&.at("./ancestor::xmlns:term/@language")&.text | ||
| @i18n = @i18n_lg[lg] if lg && @i18n_lg[lg] | ||
| elem.replace(l10n("#{@i18n.source}: #{sources}")) | ||
| @i18n = @i18n_lg["default"] |
| @is_iev or return super | ||
| lg = elem&.at("./ancestor::xmlns:term/@language")&.text | ||
| @i18n = @i18n_lg[lg] if lg && @i18n_lg[lg] | ||
| elem.replace(l10n("#{@i18n.source}: #{sources}")) |
| node.children =(l10n("<p>#{label}: " \ | ||
| "#{to_xml(p)} (#{Common::to_xml(ref)})</p>")) | ||
| @i18n = @i18n_lg["default"] | ||
| end |
There was a problem hiding this comment.
end at 204, 6 is not aligned with def at 196, 12.
| @i18n = @i18n_lg[lg] if lg && @i18n_lg[lg] | ||
| p, ref, orig = related1_prep(node) | ||
| label = @i18n.relatedterms[orig["type"]].upcase | ||
| node.children =(l10n("<p>#{label}: " \ |
There was a problem hiding this comment.
Surrounding space missing for operator =.
| def related(docxml) | ||
| docxml.xpath(ns("//term[related]")).each { |f| move_related(f) } | ||
| #docxml.xpath(ns("//term[related]")).each { |f| move_related(f) } |
| lg = p.at(ns("./expression/@language"))&.text or next | ||
| lgs.include?(lg) and next | ||
| s.parent.remove | ||
| end |
There was a problem hiding this comment.
end at 161, 6 is not aligned with term.xpath(ns(".//fmt-preferred/p/semx[@element = 'preferred']")).each do |s| at 156, 8.
| @@ -125,18 +152,36 @@ def otherlang_designations1(term, lgs) | |||
| term << "<dl type='other-lang'>#{prefs.join}</dl>" | |||
| end | |||
|
|
|||
| def remove_otherlang_designations1(term, lgs) | |||
| term.xpath(ns(".//fmt-preferred/p/semx[@element = 'preferred']")).each do |s| | |||
| p = semx_orig(s, term) | |||
There was a problem hiding this comment.
Use 2 (not 4) spaces for indentation.
| @@ -125,18 +152,36 @@ def otherlang_designations1(term, lgs) | |||
| term << "<dl type='other-lang'>#{prefs.join}</dl>" | |||
| end | |||
|
|
|||
| def remove_otherlang_designations1(term, lgs) | |||
| term.xpath(ns(".//fmt-preferred/p/semx[@element = 'preferred']")).each do |s| | |||
| e = p.at(ns("./expression")) | ||
| e.delete("language") | ||
| designation_annotate(p, p.at(ns(".//name")), d.parent) | ||
| m << { lang: lg, script: Metanorma::Utils.default_script(lg), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/issues/630
Metanorma PR checklist