Fix a small bug in NetworkingRouter #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Funkatronics
approved these changes
Aug 2, 2023
|
I give my blessing but want to let @ajamaica take the final call |
|
this mirrors the fix made here |
|
@ajamaica can you re-run the CI |
|
Hey! I was on a flight. Sorry for not seeing this. |
ajamaica
approved these changes
Aug 4, 2023
|
Thanks Arturo! Do you know whats up with the CI? lmk if you need some help with that |
|
Not sure. I am giving time for this next months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this fix, in
NetworkingRouter.kt, when an error response comes in, the class would still try and read frominputStream. In the error case, that may not exist, so it throws an exception.Work Completed
This PR fixes the bug in NetworkingRouter. It mirrors a fix that was made by @Funkatronics in the other metaplex kt lib.