use cmp_pubkeys from mpl-utils instead of token auth rules #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelvanderwaal
requested review from
febo and
danenbm
and removed request for
a team
febo
approved these changes
Jun 16, 2023
danenbm
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token Auth Rules v1.4 moved
cmp_pubkeysto a different module which breaks this import in Token Metadata. We should be using thecmp_pubkeysfrommpl-utilsinstead here for consistency anyway.Token Auth Rules should also add the function back to the previous location as it shouldn't be making a public API change in a minor version release. Then patch release a v1.4.1 version with the
cmp_pubkeysback in theprocessormodule to fix anyone stuck on an older version of Token Metadata.#1118
metaplex-foundation/mpl-token-auth-rules#134