-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smol fix for process_remove_member.rs #1166
Open
staccDOTsol
wants to merge
8
commits into
metaplex-foundation:master
Choose a base branch
from
staccDOTsol:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jan 10, 2024
-
Update process_remove_member.rs
plz sers, I will earn so much of my hydra wasted efforts back if we can fix the remove Member ix. expected behavior: feed it a member (which is seeded as mint of membership voucher) and a destination (native account) and it works actual behavior: it does a check to see if member is owned by spl token, errors if so with "InvalidCloseAccountDestination. Error Number: 6024. Error Message: Sending Sol to a SPL token destination will render the sol unusable." fix: this check is meant for the destination, to see if it is a native account. do a switcheroo and the checks should pass.
Configuration menu - View commit details
-
Copy full SHA for 1afee7b - Browse repository at this point
Copy the full SHA 1afee7bView commit details -
Update process_remove_member.rs
it's actually better like this, tbf.
Configuration menu - View commit details
-
Copy full SHA for db2c9bd - Browse repository at this point
Copy the full SHA db2c9bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7980d59 - Browse repository at this point
Copy the full SHA 7980d59View commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8a6e022 - Browse repository at this point
Copy the full SHA 8a6e022View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39e6609 - Browse repository at this point
Copy the full SHA 39e6609View commit details
Commits on Aug 24, 2024
-
Jarett Dunn authored and Jarett Dunn committed
Aug 24, 2024 Configuration menu - View commit details
-
Copy full SHA for 37ab397 - Browse repository at this point
Copy the full SHA 37ab397View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5712707 - Browse repository at this point
Copy the full SHA 5712707View commit details
Commits on Aug 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 26bf8fb - Browse repository at this point
Copy the full SHA 26bf8fbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.