-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contains and ends-with Metapath functions #168
Add contains and ends-with Metapath functions #168
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, your speed gives me anxiety. 😅
- Slightly more code, but I really like the
... NAME = "...";
constants to make copy-pasting a relevant function given similar args and behavior even easier for a novice to use and dig in with easily tactical replacements and even easier to spot diffs on changes and/or new function definition. It makes me happy. - I do not want to block, but I noticed on the two new fns in question we are not implementing the three arg variant altogether. I am not saying I think that is important, but we may want to document that we do not support (for now or semi-permanent WONTFIX emphasis) and explain why. But that is very minor consideration not worthy of blocking a PR.
Again, nice work!
core/src/main/java/gov/nist/secauto/metaschema/core/metapath/function/library/ArraySize.java
Show resolved
Hide resolved
core/src/main/java/gov/nist/secauto/metaschema/core/metapath/function/library/ArrayPut.java
Show resolved
Hide resolved
core/src/main/java/gov/nist/secauto/metaschema/core/metapath/function/library/ArrayJoin.java
Show resolved
Hide resolved
.../main/java/gov/nist/secauto/metaschema/core/metapath/function/library/ArrayInsertBefore.java
Show resolved
Hide resolved
core/src/main/java/gov/nist/secauto/metaschema/core/metapath/function/library/ArrayGet.java
Show resolved
Hide resolved
core/src/main/java/gov/nist/secauto/metaschema/core/metapath/function/library/ArrayAppend.java
Show resolved
Hide resolved
core/src/main/java/gov/nist/secauto/metaschema/core/metapath/function/library/ArrayReverse.java
Show resolved
Hide resolved
core/src/main/java/gov/nist/secauto/metaschema/core/metapath/function/library/FnContains.java
Outdated
Show resolved
Hide resolved
core/src/main/java/gov/nist/secauto/metaschema/core/metapath/function/library/FnContains.java
Show resolved
Hide resolved
core/src/main/java/gov/nist/secauto/metaschema/core/metapath/function/library/FnEndsWith.java
Show resolved
Hide resolved
Sorry, I didn't catch the merge conflict before ... |
0f43a69
to
3e5c629
Compare
3e5c629
to
9722f9b
Compare
81f681a
into
metaschema-framework:develop
Committer Notes
Added support for the contains and ends-with Metapath functions.
Also, cleaned up signatures for existing tests to reduce their visability.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: