-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacto py4cast start #102
base: main
Are you sure you want to change the base?
Conversation
def cli_main(args: ArgsType = None): | ||
cli = LightningCLI( | ||
MAELightningModule, | ||
DummyDataModule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pas encore de autoencoderDataModule donc pour l'instant comportement encoder-decoder (x!=y) et pas autoencoder(x=y).
from py4cast.datasets import get_datasets | ||
|
||
# A SUPPRIMER | ||
from py4cast.datasets.base import TorchDataloaderSettings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A terme, enlever TorchDataLoaderSettings -> modifier base.py
@clemoule Is this PR ready for review or is it a draft ? |
The code can be executed but i need to verify the plot/log method. We will discuss of the way to redesign the trainers, parsers, lightningmodule and datamodule this afternoon. So this is more of a draft even though it works. We will be set this afternoon. |
storing functions in classes (ex: PlotLightningModule) is a bit of over engineering but it helps to group functions and methods by purpose. It makes the code easier to map and understand => quicker to pick up the code => quicker to implement additions to the code and quicker to tinker |
I think it's also a good thing to decouple computing metrics and making plots. |
implementation of :