Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard against null.data error ref #108 #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dcsan
Copy link
Contributor

@dcsan dcsan commented Mar 9, 2015

i made a separate branch just for this tiny fix. you maybe don't want console.warns output but better than errors in the console.

@nickw
Copy link

nickw commented Mar 9, 2015

Thanks @dcsan. I actually started using this pattern in other components: https://github.com/meteoric/meteor-ionic/blob/master/components/ionModal/ionModal.js#L66 - perhaps we should stick with that?

@dcsan
Copy link
Contributor Author

dcsan commented Mar 10, 2015

that looks good. coffescript has default args and also the ?= operator...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants