Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom metrics #241

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Custom metrics #241

merged 3 commits into from
Oct 7, 2024

Conversation

charlienegri
Copy link
Contributor

Summary: define custom metrics to be collected together with the standard ones from the prometheus-flask-exporter

Related issue: #220

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@charlienegri charlienegri marked this pull request as ready for review October 7, 2024 12:17
@charlienegri
Copy link
Contributor Author

@magnarem tested this running the container locally and it seems to work there at least...
Screenshot from 2024-10-07 14-18-14

@charlienegri charlienegri requested a review from magnarem October 7, 2024 12:19
Copy link
Contributor

@magnarem magnarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Merging

@charlienegri charlienegri merged commit c459c4a into main Oct 7, 2024
5 checks passed
@charlienegri charlienegri deleted the custom_metrics branch October 7, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants