Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GunicornInternalPrometheusMetrics #243

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

charlienegri
Copy link
Contributor

@charlienegri charlienegri commented Oct 7, 2024

Summary: this avoids starting an extra http server for the metrics (which is what GunicornPrometheusMetrics does) at port 9200,
the problem with that is that when running the container locally all metrics get redirected at the right endpoint via port 9200, but when running in kubernetes the custom metrics and the flask standard metrics seem to be sent to different ports... here we try to avoid that
it will need an edit to the tjeneste repo to scrape port 8000 instead of 9200

Related issue: #220

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@charlienegri charlienegri changed the title use GunicornPrometheusMetrics use GunicornInternalPrometheusMetrics Oct 7, 2024
@charlienegri
Copy link
Contributor Author

@charlienegri charlienegri requested a review from magnarem October 7, 2024 17:29
@charlienegri charlienegri marked this pull request as ready for review October 7, 2024 17:31
@charlienegri
Copy link
Contributor Author

Screenshot from 2024-10-07 19-30-03
local test works... but then again this is no guarantee

Copy link
Contributor

@magnarem magnarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and merged. Lets hope this works now.

@magnarem magnarem merged commit a79acd8 into main Oct 8, 2024
5 checks passed
@magnarem magnarem deleted the custom_metrics_patch_2 branch October 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants