use GunicornInternalPrometheusMetrics #243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: this avoids starting an extra http server for the metrics (which is what GunicornPrometheusMetrics does) at port 9200,
the problem with that is that when running the container locally all metrics get redirected at the right endpoint via port 9200, but when running in kubernetes the custom metrics and the flask standard metrics seem to be sent to different ports... here we try to avoid that
it will need an edit to the tjeneste repo to scrape port 8000 instead of 9200
Related issue: #220
Suggested reviewer(s):
Reviewer checklist:
The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.