Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding vmrno2 for emep/mscw model-output #1306

Merged
merged 3 commits into from
Aug 14, 2024
Merged

adding vmrno2 for emep/mscw model-output #1306

merged 3 commits into from
Aug 14, 2024

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented Aug 14, 2024

Change Summary

The emep/mscw model can output SURF_ppb_NO2 rather than SURF_ug_NO2. Adding this variable as vmrno2 rather than calculation from the ug.

Related issue number

discussed in email @mifads

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@heikoklein heikoklein added this to the m2024-08 milestone Aug 14, 2024
@heikoklein heikoklein marked this pull request as ready for review August 14, 2024 07:11
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (8355b4a) to head (ba4d33a).
Report is 3 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1306   +/-   ##
=========================================
  Coverage     79.00%   79.00%           
=========================================
  Files           136      136           
  Lines         20797    20797           
=========================================
  Hits          16430    16430           
  Misses         4367     4367           
Flag Coverage Δ
unittests 79.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨

@thorbjoernl thorbjoernl merged commit cbf1aed into main-dev Aug 14, 2024
8 checks passed
@thorbjoernl thorbjoernl deleted the emep-vmrno2 branch August 14, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants