Fix mda8 misalignment #1322
Merged
Fix mda8 misalignment #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1322 +/- ##
============================================
- Coverage 78.97% 78.96% -0.01%
============================================
Files 136 136
Lines 20812 20813 +1
============================================
Hits 16436 16436
- Misses 4376 4377 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thorbjoernl
changed the title
avaldebe
previously requested changes
Aug 23, 2024
pyaerocom/stats/mda8/mda8.py
Outdated
| new_arr = arr.rolling(time=8, min_periods=6).mean() | ||
| # Xarray labels the data left, while we want it to be labeled right, so we add 8h to | ||
| # the time index. | ||
| new_arr["time"] = new_arr.get_index("time") + pd.Timedelta("8h") |
There was a problem hiding this comment.
Why is the new_arr.get_index("time") needed?
Can it be written as
new_arr["time"] += pd.Timedelta("8h")There was a problem hiding this comment.
+= Doesn't work.
This is the documented way of doing time offset arithmetic: https://github.com/pydata/xarray/pull/8479/files
heikoklein
approved these changes
Sep 11, 2024
heikoklein
dismissed
avaldebe’s stale review
Alvaro is on leave, and his change requests have been addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Per discusion with @avaldebe, there is an issue where the mda8 calculation relies on undocumented xarray behaviour. This PR aims to make arguments explicit where possible as well as testing for the undocumented behaviour in xarray so that possible future regressions can be detected. This also fixes an issue where 8 hour average was left labeled instead of rightlabeled, resulting in the mda8 binning to be shifted by 8 hours from the defined window.
Related issue number
closes #1323
Checklist