Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conco3mda8 to fairmode stats #1328

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

charlienegri
Copy link
Collaborator

@charlienegri charlienegri commented Aug 28, 2024

Change Summary

conco3mda is the variable that should be used for fairmode stats, we leave conco3 there for now but in principle it can be removed at some point

Related issue number

trying to close #1327

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@charlienegri
Copy link
Collaborator Author

testing this with an experiment

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (9e48af9) to head (56401dd).
Report is 14 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1328      +/-   ##
============================================
- Coverage     78.97%   78.96%   -0.01%     
============================================
  Files           136      136              
  Lines         20812    20813       +1     
============================================
  Hits          16436    16436              
- Misses         4376     4377       +1     
Flag Coverage Δ
unittests 78.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charlienegri charlienegri marked this pull request as ready for review August 28, 2024 11:17
@heikoklein heikoklein merged commit b4704be into main-dev Aug 28, 2024
8 checks passed
@heikoklein heikoklein deleted the add_conco3mda8_fairmode branch August 28, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no fairmode stats for conco3mda8
2 participants