Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var_order_menu has to have all the relevant variables if used since sep 2 2024 #1334

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

charlienegri
Copy link
Collaborator

@charlienegri charlienegri commented Sep 4, 2024

Change Summary

var_order_menu is now used by the front end so the config for cams2_83 needs to be fixed

Related issue number

fixes #1333

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (48a93f8) to head (d1b8461).
Report is 3 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1334   +/-   ##
=========================================
  Coverage     78.97%   78.97%           
=========================================
  Files           136      136           
  Lines         20814    20814           
=========================================
  Hits          16437    16437           
  Misses         4377     4377           
Flag Coverage Δ
unittests 78.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charlienegri charlienegri marked this pull request as ready for review September 4, 2024 08:02
@charlienegri
Copy link
Collaborator Author

if this is correct we need to merge it today ideally because I need to deploy it to a new version of the module and use it for production, otherwise the configs will be overwritten tomorrow morning

@heikoklein heikoklein merged commit 87d84b3 into main-dev Sep 4, 2024
8 checks passed
@heikoklein heikoklein deleted the fix_menu branch September 4, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong set of variables end up in "var_order_menu"
2 participants