Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds better definition of filters. Adds tqdm to read_pyaro #1335

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Sep 5, 2024

Change Summary

Small changes to make the definition of pyaro filters more in line with pyaro. Makes the eea reader work

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@dulte dulte added the bug 🐛 Something isn't working label Sep 5, 2024
@dulte dulte added this to the m2024-09 milestone Sep 5, 2024
@dulte dulte self-assigned this Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (d1b8461) to head (80a44e1).
Report is 4 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1335   +/-   ##
=========================================
  Coverage     78.97%   78.97%           
=========================================
  Files           136      136           
  Lines         20814    20815    +1     
=========================================
+ Hits          16437    16438    +1     
  Misses         4377     4377           
Flag Coverage Δ
unittests 78.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dulte dulte marked this pull request as ready for review September 5, 2024 12:20
@heikoklein heikoklein merged commit cc6279e into main-dev Sep 5, 2024
8 checks passed
@heikoklein heikoklein deleted the fix_read_pyaro_filters branch September 5, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants