Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ebas files for carbon-component with pure statistics #1341

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented Sep 12, 2024

Ebas has a few old files with pure statistics, e.g. uncertainties. Avoid these files by selecting only files which have also arithmetic mean.

Change Summary

adding statistics to ebas.ini

Related issue number

chat-message from Hilde

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@heikoklein heikoklein added this to the m2024-10 milestone Sep 12, 2024
@heikoklein heikoklein marked this pull request as ready for review September 12, 2024 14:18
Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (2ae1c47) to head (4a7bece).
Report is 21 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1341   +/-   ##
=========================================
  Coverage     78.97%   78.97%           
=========================================
  Files           136      136           
  Lines         20815    20815           
=========================================
  Hits          16438    16438           
  Misses         4377     4377           
Flag Coverage Δ
unittests 78.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heikoklein heikoklein merged commit be7aeef into main-dev Sep 12, 2024
8 checks passed
@heikoklein heikoklein deleted the fix_statistics branch September 12, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants