Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unit conversion to read_pyaro #1343

Closed
wants to merge 3 commits into from
Closed

Adds unit conversion to read_pyaro #1343

wants to merge 3 commits into from

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Sep 16, 2024

Change Summary

After some problems with the EEA reader and units, I've added unit conversion to read_pyaro

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@dulte dulte added the enhancement ✨ New feature or request label Sep 16, 2024
@dulte dulte added this to the m2024-10 milestone Sep 16, 2024
@dulte dulte self-assigned this Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (4a7bece) to head (f7a088f).
Report is 16 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1343      +/-   ##
============================================
+ Coverage     78.97%   78.98%   +0.01%     
============================================
  Files           136      136              
  Lines         20815    20831      +16     
============================================
+ Hits          16438    16454      +16     
  Misses         4377     4377              
Flag Coverage Δ
unittests 78.98% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dulte dulte marked this pull request as ready for review September 16, 2024 17:40
@dulte dulte marked this pull request as draft September 16, 2024 19:05
@dulte
Copy link
Collaborator Author

dulte commented Sep 16, 2024

It is more or less done. But I get strange results with my calculated factor for the conversion between mg S/l and ugm-3. The resulting observations from EEA then gets 6 order of magnitude larger than the model. So there is something I don't understand with the mgS/l units...

@dulte
Copy link
Collaborator Author

dulte commented Sep 23, 2024

This might be the wrong way of handling the units. Will remove PR as of now

@dulte dulte closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant