Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce test warnings #1456

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Reduce test warnings #1456

merged 4 commits into from
Dec 11, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Dec 11, 2024

Change Summary

Fixes issues that lead to the following warnings:

  • ResourceWarning due to a unclosed file handle.
  • DeprecationWarning due to not indexing 1d array before converting to scalar.

After these changes the only warnings remaining are the matplotlib related ones, and the iris default sphere ones we decided to ignore in #1394

Related issue number

#1066 (Remember to push this forward two milestones when merging)

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally (except Issue with test pytest tests/io/test_read_aeronet_invv3.py #1455 )
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl self-assigned this Dec 11, 2024
@thorbjoernl thorbjoernl added this to the m2025-01 milestone Dec 11, 2024
@thorbjoernl thorbjoernl marked this pull request as ready for review December 11, 2024 14:26
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 78.72340% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.43%. Comparing base (239efbc) to head (11c11fb).
Report is 8 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/io/ebas_nasa_ames.py 77.27% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1456   +/-   ##
=========================================
  Coverage     78.43%   78.43%           
=========================================
  Files           137      137           
  Lines         20961    20963    +2     
=========================================
+ Hits          16440    16442    +2     
  Misses         4521     4521           
Flag Coverage Δ
unittests 78.43% <78.72%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks very good.

@heikoklein heikoklein merged commit 6976a35 into main-dev Dec 11, 2024
8 checks passed
@heikoklein heikoklein deleted the check-test-warnings branch December 11, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants