-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMEP pyaro/eeareader #1463
EMEP pyaro/eeareader #1463
Conversation
c41d701
to
7e2478c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1463 +/- ##
============================================
- Coverage 78.49% 78.48% -0.01%
============================================
Files 139 139
Lines 21090 21084 -6
============================================
- Hits 16554 16548 -6
Misses 4536 4536
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
64ee506
to
e1f6229
Compare
e1f6229
to
378e441
Compare
Why did you split out NO into a separate entry? |
It used to be it's own component for some reason and I've kept it like that |
Ok, looks strange that the post_processing and name_match sections don't match the obs_vars, though. Not sure why we still need to split NO, now that it should be included in all outputs. For simplicity, just keep it merged. |
75da8a0
to
378e441
Compare
@thorbjoernl Are you familiar with the cause of the CI failure? |
No. It may be related to the emep changes I've made, but I don't think any of those PRs caused this issue on their own. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Change Summary
Utilise the pyaro eeareader for the emep report template
Result at https://aeroval-test.met.no/magnusu/pages/evaluation/?project=eeareadertest&experiment=2024-reporting-mock-postprocess-3&station=ALL¶meter=concNno#
Missing the
vmrox
variableSomething is broken when comparing EMEP/EBAS-h asconcNno
,concpm10,
concpm25` are fetched, even when the emep hourly does not contain these variables. This might be a result of changed data, but is not related to this PR.The pyaro reader of the EEA data is stricter than the previous reader, which results in less datapoints.
Related issue number
Fixes #1452
Checklist