Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMEP pyaro/eeareader #1463

Merged
merged 1 commit into from
Jan 7, 2025
Merged

EMEP pyaro/eeareader #1463

merged 1 commit into from
Jan 7, 2025

Conversation

magnusuMET
Copy link
Collaborator

@magnusuMET magnusuMET commented Dec 18, 2024

Change Summary

Utilise the pyaro eeareader for the emep report template

Result at https://aeroval-test.met.no/magnusu/pages/evaluation/?project=eeareadertest&experiment=2024-reporting-mock-postprocess-3&station=ALL&parameter=concNno#

Missing the vmrox variable

Something is broken when comparing EMEP/EBAS-h as concNno, concpm10, concpm25` are fetched, even when the emep hourly does not contain these variables. This might be a result of changed data, but is not related to this PR.

The pyaro reader of the EEA data is stricter than the previous reader, which results in less datapoints.

Related issue number

Fixes #1452

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@magnusuMET magnusuMET added this to the m2025-01 milestone Dec 18, 2024
@magnusuMET magnusuMET mentioned this pull request Dec 18, 2024
9 tasks
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (82a50eb) to head (75da8a0).
Report is 3 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1463      +/-   ##
============================================
- Coverage     78.49%   78.48%   -0.01%     
============================================
  Files           139      139              
  Lines         21090    21084       -6     
============================================
- Hits          16554    16548       -6     
  Misses         4536     4536              
Flag Coverage Δ
unittests 78.48% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magnusuMET magnusuMET force-pushed the emep_eeareader branch 2 times, most recently from 64ee506 to e1f6229 Compare December 18, 2024 11:35
@magnusuMET magnusuMET requested a review from heikoklein January 3, 2025 14:50
@magnusuMET magnusuMET marked this pull request as ready for review January 3, 2025 14:50
@heikoklein
Copy link
Member

Why did you split out NO into a separate entry?

@magnusuMET
Copy link
Collaborator Author

It used to be it's own component for some reason and I've kept it like that

@heikoklein
Copy link
Member

Ok, looks strange that the post_processing and name_match sections don't match the obs_vars, though.

Not sure why we still need to split NO, now that it should be included in all outputs. For simplicity, just keep it merged.

@magnusuMET
Copy link
Collaborator Author

@thorbjoernl Are you familiar with the cause of the CI failure?

@thorbjoernl
Copy link
Collaborator

@thorbjoernl Are you familiar with the cause of the CI failure?

No. It may be related to the emep changes I've made, but I don't think any of those PRs caused this issue on their own.

Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@heikoklein heikoklein merged commit e4e37c4 into main-dev Jan 7, 2025
13 checks passed
@heikoklein heikoklein deleted the emep_eeareader branch January 7, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use EEAReader in emep config
3 participants