Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of proxy vars for contours and overlays #1489

Open
wants to merge 1 commit into
base: main-dev
Choose a base branch
from

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Jan 20, 2025

Change Summary

Grabs the renaming of variables from a config for contours and overlays if provided. Otherwise, the original variable name is used.

Related issue number

Close #902

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@lewisblake lewisblake added the CAMS2_82 Issues related to the CAMS2_82 contract label Jan 20, 2025
@lewisblake lewisblake added this to the m2025-02 milestone Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (ee2f859) to head (9591a7d).
Report is 10 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1489      +/-   ##
============================================
- Coverage     78.46%   78.46%   -0.01%     
============================================
  Files           139      139              
  Lines         21120    21119       -1     
============================================
- Hits          16571    16570       -1     
  Misses         4549     4549              
Flag Coverage Δ
unittests 78.46% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake marked this pull request as ready for review January 20, 2025 15:17
@lewisblake lewisblake changed the title introduce renaming for contours and overlays Renaming of proxy vars for contours and overlays Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CAMS2_82 Issues related to the CAMS2_82 contract
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxyod* vars are not renamed in contour catalogue
1 participant