Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tempfile #694

Merged
merged 12 commits into from
Jul 5, 2022
Merged

No tempfile #694

merged 12 commits into from
Jul 5, 2022

Conversation

avaldebe
Copy link
Collaborator

@avaldebe avaldebe commented Jul 5, 2022

Address some of the problems behind #692 by providing temporary files as fixtures.
These changes makes possible to run multiple tests in parallel with pytest-xdist.

@avaldebe avaldebe added this to the v0.13.2 milestone Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #694 (d29b3a5) into main-dev (e9f2666) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           main-dev     #694      +/-   ##
============================================
- Coverage     76.81%   76.79%   -0.03%     
============================================
  Files            97       97              
  Lines         17536    17536              
============================================
- Hits          13471    13466       -5     
- Misses         4065     4070       +5     
Flag Coverage Δ
unittests 76.79% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/io/iris_io.py 93.07% <0.00%> (-1.54%) ⬇️
pyaerocom/io/helpers.py 70.49% <0.00%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9f2666...d29b3a5. Read the comment docs.

@avaldebe
Copy link
Collaborator Author

avaldebe commented Jul 5, 2022

[...] These changes makes possible to run multiple tests in parallel with pytest-xdist.

Unfortunately, it does not work consistently on CI.

@avaldebe avaldebe marked this pull request as ready for review July 5, 2022 14:43
@avaldebe avaldebe merged commit 31284db into metno:main-dev Jul 5, 2022
@avaldebe avaldebe deleted the no-tempfile branch July 5, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants