-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
32 add pyaro ebas reader for nilu pmf data as well as general use #35
32 add pyaro ebas reader for nilu pmf data as well as general use #35
Conversation
After half a day of working on this, I realised that the approach of transforming the existing EBAS reader will not work due to too deep cross imports / improper dependency handling. Importing the EBAS reader class has even a dependency on the gridded data object. I will therefore start from pyaro and just steal from the EBAS reader class what's really needed for PMF while trying to keep the readability of all ebas variables supported by pyaerocom. At this point I'm not sure how well that will work. The focus might become to just read the PMF data. |
…dd-pyaro-ebas-reader-for-nilu-pmf-data-as-well-as-general-use # Conflicts: # README.md # setup.cfg
…nilu-pmf-data-as-well-as-general-use # Conflicts: # setup.cfg
The pyaro-readers part is finished, but we are missing the pyaerocom glue to EBAS. The problem is that for EBAS data there is no 1:1 connection between the variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested a handful of changes.
It would also be good to add docstrings and perhaps type-hints to functions, as some of them lack clear documentation currently.
...180809104500.high_vol_sampler.oc_ec_tc.pm25.3mo.3d.AT05L_hvs_02.AT05L_TU_sunset_001.lev2.nas
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 🚀
…nilu-pmf-data-as-well-as-general-use # Conflicts: # setup.cfg
…u-pmf-data-as-well-as-general-use' into 32-add-pyaro-ebas-reader-for-nilu-pmf-data-as-well-as-general-use # Conflicts: # setup.cfg
add EBAS reader that doesn't need the SQLite database since it's not provided by the PMF dataset.
Use as much from the pyaerocom EBAS reader as possible.