Update bufr.py for carra2 for local observations #35
Conversation
|
Can you try to add only your changes? You have removed some of the last developments I think (sigmao etc) |
pysurfex/bufr.py
Outdated
| @@ -1,5 +1,6 @@ | |||
| """bufr treatment.""" | |||
| import logging | |||
| import sys | |||
pysurfex/bufr.py
Outdated
| try: | ||
| value = self.td2rh(td2m, t2m) | ||
| value = value * 0.01 | ||
| value = value * 0.01 |
There was a problem hiding this comment.
Remove the white-spaces
|
The unit tests fail because we now require stationOrSiteName in the bufr file. Is it ok to have such a requirement @PerDahlgren ? Will this key always be existing? |
|
stationOrSiteName will not always be existing, only in some bufr templates.
I am a bit confused because this worked when I ran harmonie, with bufr
input that was a mix of different bufr-templates, some
with stationOrSiteName and some without it.
tir. 16. jan. 2024 kl. 10:14 skrev Trygve Aspelien ***@***.***
…:
The unit tests fail because we now require stationOrSiteName in the bufr
file. Is it ok to have such a requirement @PerDahlgren
<https://github.com/PerDahlgren> ? Will this key always be existing?
—
Reply to this email directly, view it on GitHub
<#35 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWUSAIVUIDOMLTBU5PDO4WTYOZAHRAVCNFSM6AAAAABBX27BRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGM2DCOJTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
The fail, in the test, seems to come from eccodes.codes_get(bufr, key). |
|
@PerDahlgren, this crash has nothing to do with eccodes' version since when running the testsuite real reading functions of eccodes are replaced by stubs which return values from a test BUFR file implemented as a python dictionary (see conftest.py#L425-L447). Since in your PR you add a new So, as @trygveasp mentioned, if |
Added features in bufr.py for carra2 to be able to read local observations