Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to pyproject.toml #240

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Switch to pyproject.toml #240

merged 5 commits into from
Oct 20, 2023

Conversation

MetRonnie
Copy link
Contributor

@MetRonnie MetRonnie commented Oct 18, 2023 •
edited
Loading

@MetRonnie MetRonnie added this to the 3.2.0 milestone Oct 18, 2023
@MetRonnie MetRonnie self-assigned this Oct 18, 2023
@MetRonnie MetRonnie mentioned this pull request Oct 18, 2023
Merged
@MetRonnie MetRonnie marked this pull request as ready for review October 19, 2023 10:30
@MetRonnie
Switch to pyproject.toml
99bb35e
@MetRonnie
Add pytest-xdist as test dependency & improve GH Actions
a28e52f 
GH Actions:
- Use more processes in xdist for speedup
- Upload coverage to Codecov in separate job
- Add build test
- General TLC
@MetRonnie
Support python 3.12
a59c119
oliver-sanders
oliver-sanders approved these changes Oct 19, 2023
View reviewed changes
.github/workflows/test.yml
Comment on lines +62 to +66
- name: Coverage report
if: matrix.coverage
run: |
coverage xml --ignore-errors
bash <(curl -s https://codecov.io/bash)
coverage xml
coverage report
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this bit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage xml - I think this is needed to convert the data into a compatible format for Codecov? But not sure.

coverage report - Not strictly needed but can be useful to see the coverage stats sometimes

@oliver-sanders
Copy link
Member

oliver-sanders commented Oct 19, 2023 •
edited
Loading

It might be worth taking the opportunity to roll the pytest.ini and .bandit files into this (& .coveragerc maybe?).

@MetRonnie
Copy link
Contributor Author

(& .coveragerc maybe?).

Decided against this as coverage configs can be quite lengthy and also the exclusion regexes would need extra escaping in TOML

wxtim
wxtim approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looks good
  • Tried it locally with a couple of different pythons

@wxtim wxtim merged commit 05627f1 into metomi:master Oct 20, 2023
18 checks passed
@MetRonnie MetRonnie deleted the pyproject branch October 20, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @oliver-sanders @wxtim