Upgrade rose edit to Python 3 #2808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow!
|
Comment on lines
379
to
479
| val_array = [] | ||
| # Prevent str without "" breaking the underlying Python syntax | ||
| for e in self.entries: | ||
| v = e.get_text() | ||
| if v in ("False", "True"): # Boolean | ||
| val_array.append(v) | ||
| elif (len(v) == 0) or (v[:1].isdigit()): # Empty or numeric | ||
| val_array.append(v) | ||
| elif not v.startswith('"'): # Str - add in leading and trailing " | ||
| val_array.append('"' + v + '"') | ||
| e.set_text('"' + v + '"') | ||
| e.set_position(len(v)+1) | ||
| elif (not v.endswith('"')) or (len(v) == 1): # Str - add in trailing " | ||
| val_array.append(v + '"') | ||
| e.set_text(v + '"') | ||
| e.set_position(len(v)) | ||
| else: |
There was a problem hiding this comment.
@oliver-sanders, please go through this.
astroDimitrios
force-pushed
the
feature/rose-config-py3
branch
3 times, most recently
from
5684ff9 to
4cf6267
Compare
J-J-Abram
force-pushed
the
feature/rose-config-py3
branch
from
d7fb376 to
07cd350
Compare
astroDimitrios
force-pushed
the
feature/rose-config-py3
branch
from
5684ff9 to
2dddf66
Compare
…e config-edit and an alias for edit.
…rsion script on Rose 2019.
astroDimitrios
force-pushed
the
feature/rose-config-py3
branch
from
2dddf66 to
c7c5cb4
Compare
* Fixes window top level function call * Fixes accelerator connection * Adds empty input arg for visibility functions * Fixes 2 button press usage * Fixes text buffer call * Fixes use of text buffer in TextView * Fixes select_row code * Fixes flags including SENSITIVE * Fixes insert_action_group calls * Fixes calls to _set_cell_* * Fixes page tab names * Adds in 6th arg to BaseSummaryDataPanel function for visibility functions
* Fixes inspect module calls * Fixes dict key access
Fix array widget bug which forced widgets to scroll off screen when adding an array element
* Menu button init fix in gtk/util.py. * Fix window default icon list. * Replaces Dialog Question stock id
…..HORIZONTAL), and padding option added
Feature/33 separator (#42) * 33 vertical padding added to widgets for a 'soft' distinction * Vertical padding removed, line distinctions added using css styling Removes top and bottom border from main page window
astroDimitrios
force-pushed
the
feature/rose-config-py3
branch
2 times, most recently
from
c5a6ee7 to
edd7db0
Compare
* Removed 'Run Suite...' Button * Removed Launch Suite Control _GUI from the 'Tools' dropdown, but Launch Suite Control GUI still exists in the files, need to investigate what this controls in the GUI * Remove 'Launch Suite Control GUI' button with no icon * Removed 'View Output' Button from taskbar * removed comments related to 'View Output' Button * Removed all 'Run Suite' functionality from the 'Tools' dropdown menu * Removed remaining comments related to Run Suite * 'View Output' removed from 'Tools' dropdown menu
Fixes issue with duplicate ns sorting app 10
If either section or option in the namespace (ns) are None then this doesn't sort properly with other values. This change ensures None is converted to a string to compare with normal string section/option values.
Fixes invisible text in the stash diag panel
…se-edit Removes tests for Python 3.7
…le for Rose 2.0 Removes the extra rose config-edit section from the rose api docs and prevented the splash-screen entry points getting into the docs
astroDimitrios
force-pushed
the
feature/rose-config-py3
branch
from
8d1aef1 to
f345292
Compare
|
There are some flaky tests lurking in the battery at the moment (nothing to do with this PR), the following Mac OS failures can be ignored:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed this change updates
rose config-edit(or justrose edit) to Python 3 / Gtk3.All seems to function par some cosmetic bugs which are outlined in the Issues on my fork.