Python 3 and Cylc 8 conversion #2841
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ran the Python 2 to 3 converter over the code * Fixed a number of py2 -> py3 issues around dividing two ints and getting an int vs getting a float in return * Added significant logging to assist with debugging * Put in some handling for getting None back and attempting to do a string comparison on it. * urllib.pathname2url -> urllib.request.pathname2url * Remove user_at_host from Rose Bush DAO as it's not in Cylc 8 * Nullified host, submit_method and submit_method_id as not in Cylc8 * Added exception handling to SQLite3 calls in RoseBushDAO * Coerced a lot of lists with list()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is from the 2017.10.0 tag