-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix malli swagger defs #863
Commits on Mar 6, 2023
-
Move swagger gen code from reitit-malli to here
This allows us to see the whole spec at once and fix a bug w/ custom registry definitions
Configuration menu - View commit details
-
Copy full SHA for b4fcd47 - Browse repository at this point
Copy the full SHA b4fcd47View commit details -
Properly encode the / in qualified keywords as ~1
...in json-schema. Also removes the leading `:` which the definitions keys also didn't have. This allows the refs and definitions keys to match and be standards-compliant.
Configuration menu - View commit details
-
Copy full SHA for 2e54fa8 - Browse repository at this point
Copy the full SHA 2e54fa8View commit details -
Don't define circular refs in definitions
Perhaps this really needs to be fixed at a lower level, but I noticed that at times I was getting definitions whose values where just refs back to the same definition. These seemed to come in addition to the correct result that had the actual definition in it. So this just filters out the circular ones.
Configuration menu - View commit details
-
Copy full SHA for 23488b2 - Browse repository at this point
Copy the full SHA 23488b2View commit details
Commits on Mar 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6e0701c - Browse repository at this point
Copy the full SHA 6e0701cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7edeb8a - Browse repository at this point
Copy the full SHA 7edeb8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59e4fa5 - Browse repository at this point
Copy the full SHA 59e4fa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58f7e06 - Browse repository at this point
Copy the full SHA 58f7e06View commit details
Commits on Mar 15, 2023
-
Add a test for circular definitions avoidance
...in json-schema-test/references-test. Fix was in 23488b2.
Configuration menu - View commit details
-
Copy full SHA for 64b15cb - Browse repository at this point
Copy the full SHA 64b15cbView commit details -
Add tests for swagger/swagger-spec
...including one commented-out failing test that should pass once issue metosin#464 is fixed.
Configuration menu - View commit details
-
Copy full SHA for d774bd8 - Browse repository at this point
Copy the full SHA d774bd8View commit details
Commits on Mar 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2fedffc - Browse repository at this point
Copy the full SHA 2fedffcView commit details