Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malli swagger defs #863

Merged
merged 10 commits into from
Mar 17, 2023
Merged

Commits on Mar 6, 2023

  1. Move swagger gen code from reitit-malli to here

    This allows us to see the whole spec at once and fix a bug w/ custom registry definitions
    cap10morgan committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    b4fcd47 View commit details
    Browse the repository at this point in the history
  2. Properly encode the / in qualified keywords as ~1

    ...in json-schema. Also removes the leading `:` which the definitions keys also didn't have. This allows the refs and definitions keys to match and be standards-compliant.
    cap10morgan committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    2e54fa8 View commit details
    Browse the repository at this point in the history
  3. Don't define circular refs in definitions

    Perhaps this really needs to be fixed at a lower level, but I noticed that at times I was getting definitions whose values where just refs back to the same definition. These seemed to come in addition to the correct result that had the actual definition in it. So this just filters out the circular ones.
    cap10morgan committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    23488b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Configuration menu
    Copy the full SHA
    6e0701c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7edeb8a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    59e4fa5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    58f7e06 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Add a test for circular definitions avoidance

    ...in json-schema-test/references-test. Fix was in 23488b2.
    cap10morgan committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    64b15cb View commit details
    Browse the repository at this point in the history
  2. Add tests for swagger/swagger-spec

    ...including one commented-out failing test that should pass once issue metosin#464 is fixed.
    cap10morgan committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d774bd8 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Configuration menu
    Copy the full SHA
    2fedffc View commit details
    Browse the repository at this point in the history