Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for persistent hash map formatting #16

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ilmoraunio
Copy link
Collaborator

Fixes a finding from the latest generative test run:

No method in multimethod 'format-value' for dispatch value: class clojure.lang.PersistentHashMap

The offending (reduced) payload being:

(gql '(("Px6yr3Z6"
         {:arguments {"I58LwWPr5" {"BnX8" 2,
                                   :F {},
                                   "mfvh" true,
                                   "Gx7uc" [],
                                   :l nil,
                                   :b {},
                                   "v9SN" nil,
                                   "Qpe41O8j" "304P44x3X",
                                   :gF5 :v,
                                   "m" {}}}})))

The fix was to implement format-value for hash maps using the same implementation as for array maps.

@ilmoraunio ilmoraunio merged commit 70056a8 into main Jun 7, 2024
10 checks passed
@ilmoraunio ilmoraunio deleted the persistent-hash-map-formatting branch June 7, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant