Fix malli swagger defs w/ custom registries #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...so we can fix #558.
...so that all of the absolute $ref's to them will resolve
...which should only be at the top level now.
-compile-model now takes a vector of models, so (-compile-model this model nil) fails. Just use compile directly like master does.
we only want the definitions on the very top level of the swagger doc
This was referenced Aug 30, 2023
ikitommi
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #589
fixes #558
depends on #metosin/malli#939
Lifts the definitions to the root of the swagger.json document so that
all of the $refs to them can resolve. Also fixes some naming /
encoding issues with them and a circular ref problem I was noticing
where sometimes a definition would just become a ref to itself.