Support independent request and response validation in Malli coercer #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stig
force-pushed
the
disable-response-validation
branch
from
5267f76
to
7611561
Compare
The motivation for this is adding a new API to a legacy service whose data model has evolved over the years. Maybe we cannot guarantee the presence of all fields that are considered mandatory now. Rather than blowing up when attempting to return legacy entries we may want to disable response validation. However, we do want to ensure *new* entries added to the system are valid, so we do not want to disable request validation. Retain the ability to turn off both request and response validation with a single setting for backwards compatibility.
stig
force-pushed
the
disable-response-validation
branch
from
7611561
to
f262daa
Compare
|
I take the radio silence means "not interested". I'll close this, to get it off my list of Open PRs I need to check back on every week. Feel free to re-open if you decide you're interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is adding a new API to a legacy service whose data model has evolved over the years. Maybe we cannot guarantee the presence of all fields that are considered mandatory now. Rather than blowing up when attempting to return legacy entries we may want to disable response validation.
However, we do want to ensure new entries added to the system are valid, so we do not want to disable request validation.
Retain the ability to turn off both request and response validation with a single setting for backwards compatibility.