Speed up routes and inline it in code ring handler #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikitommi
reviewed
Aug 27, 2024
| (single-arity request)) | ||
| ([request respond raise] | ||
| (multi-arity request respond raise)))))) | ||
|
|
||
| (defn routes |
There was a problem hiding this comment.
I think this could be simplified a bit.
There was a problem hiding this comment.
comp-handlers has 2 arities, routes 4. routes is not needed at request-time (thanks for the fix!) so the creation speed is not critical. dropped extra arities here: #696
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #692