Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass missing options -c, -o and -g from wrapper to logger process #42

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

thebaptiste
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Feb 9, 2024

@thebaptiste
Copy link
Contributor Author

@mk-fg As in your PR #36 for -d option, options -c, -o and -g are not passed from the wrapper to the logger
Does this PR seem ok to you ?

@thebaptiste
Copy link
Contributor Author

I have also completed the README file

@mk-fg
Copy link
Contributor

mk-fg commented Feb 9, 2024

Yes, don't see any issues.
Iirc I did leave some slack in argv array, so extending it by 5 while adding potentially 6 options should be fine.
(iirc it should be NULL-terminated, but otherwise can be of any size, so should be fine as long as everything fits)

Wasn't sure if maybe these options were omitted on purpose when looking at them earlier after seeing -d missing there, so kinda ignored and forgot about them.

@mk-fg
Copy link
Contributor

mk-fg commented Feb 9, 2024

I have also completed the README file

Oh, right, forgot that it had a list of options too, should've at least added -T there earlier. Thanks.

@thebaptiste thebaptiste merged commit ed02932 into master Feb 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants